fix(web): revert functionality to remember last workspace opened #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 26.66% 26.70% +0.03%
==========================================
Files 1337 1337
Lines 144689 144412 -277
Branches 3483 3481 -2
==========================================
- Hits 38579 38560 -19
+ Misses 104988 104730 -258
Partials 1122 1122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KaWaite
changed the title
isoppp
reviewed
Jun 28, 2023
|
|
||
| navigate(`/dashboard/${workspaceId}`); | ||
| } else { | ||
| setCurrentUserId(data?.me?.id); |
There was a problem hiding this comment.
I think this function had two functionalities.
a. Handle redirect
b. Set user id if currentUserId !== data?.me?.id
This modification looks like losing b, is it merely unnecessary code?
It might be necessary when switching accounts.
| setLastWorkspace(currentWorkspace); | ||
| navigate(`/dashboard/${workspaceId}`); | ||
| } else { | ||
| setCurrentUserId(data?.me?.id); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We were getting an infinite loop on the Dashboard that was hurting the server (probably).
The logic around remembering the previous workspace was hard to understand and maintain, so I decided to remove that implementation so we can get Re:Earth back to a working condition and then reimplement that functionality later.